fix(core): decode encoded cookie name while creating universal storage #11984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
#11945
Description of how you validated changes
Context
When
Amplify.configure({ ssr: true })
, the Cognito auth tokens will be stored in cookie store. This is handled by the packageamazon-cognito-identity-js
usingjs-cookie
under the hood.Per RFC 6265 section 4.1.1 and RFC 2616 section 2.2, a cookie name must be a
token
that doesn't contain any separators.In the situation described in the linked issue, the cookie name contains
'@'
as a part of user email address, hence,js-cookie
encodes it following above the aforementioned standard. However, theUniversalStorage
creates a cookie store instance using the cookie header value directly, without decoding it, this further caused the issue.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.