fix(interactions): align type names and use named params #12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
reviewed
Oct 25, 2023
| completion?: InteractionsResponse | ||
| ) => void; | ||
|
|
||
| export type InteractionsResponse = { |
There was a problem hiding this comment.
Kept the V5 types as it is in Interactions.ts. just added wrapper interfaces for these to avoid too much change
There was a problem hiding this comment.
The lexV1 / V2 provider classes still use these types
5d
previously approved these changes
Oct 25, 2023
5d
approved these changes
Oct 26, 2023
jimblanc
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
API, types change
send,onCompleteAPIs named params (lexV1 and V2)SendInput,SendOutput,OnCompleteInput(naming format<ApiName>Input/<ApiName>Output) for lexV1 and V2Folder structure
input.tsandoutput.tsfiles for exposing above mentioned types for APIs (lexV1 and V2)Description of how you validated changes
Exported items
(Before)
(After)
DX
(Before: positional params)
(After: named params)
Tested Unit test, Integ test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.