feat(data): pass request options to custom header functions #12572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d types; add custom headers for subscriptions
david-mcafee
force-pushed
the
fn-headers-args
branch
from
0f64b92
to
8095221
Compare
david-mcafee
force-pushed
the
fn-headers-args
branch
from
1d922d0
to
934d7d4
Compare
david-mcafee
commented
Dec 12, 2023
| @@ -66,23 +66,23 @@ function makeAppSyncStreams() { | |||
| * replaces fields that are likely to change between calls (or library version revs) | |||
| * with static values. When possible, on the unpredicable portions of these values | |||
| * are replaced. | |||
| * | |||
There was a problem hiding this comment.
Looks like this file was previously updated without Prettier - I've added comments below to assist with identifying the added tests.
david-mcafee
commented
Dec 12, 2023
| @@ -2795,7 +2795,46 @@ describe('generateClient', () => { | |||
| description: 'something something', | |||
| }); | |||
|
|
|||
| expect(normalizePostGraphqlCalls(spy)).toMatchSnapshot() | |||
| expect(normalizePostGraphqlCalls(spy)).toMatchSnapshot(); | |||
david-mcafee
commented
Dec 12, 2023
| @@ -2894,7 +2933,53 @@ describe('generateClient', () => { | |||
| } | |||
| ); | |||
|
|
|||
| expect(normalizePostGraphqlCalls(spy)).toMatchSnapshot() | |||
| expect(normalizePostGraphqlCalls(spy)).toMatchSnapshot(); | |||
david-mcafee
commented
Dec 12, 2023
| @@ -3313,6 +3398,50 @@ describe('generateClient', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('can subscribe to onCreate() - with a custom header function that accepts requestOptions', done => { | |||
svidgen
reviewed
Dec 12, 2023
packages/api-graphql/__tests__/AWSAppSyncRealTimeProvider.test.ts
Outdated
Show resolved
Hide resolved
david-mcafee
force-pushed
the
fn-headers-args
branch
from
bbe159f
to
7d14675
Compare
|
The change looks fine. For posterity's sake, can you add a description to this PR that captures what customer behavior is changing with this diff and confirm that you've tested the behavior in a sample app? Happy to approve this once the description is filled in a bit. |
Good callout! This has been added. |
stocaaro
approved these changes
Dec 13, 2023
svidgen
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR updates the API GraphQL category, as well as the AWSAppSyncRealTimeProvider, to send request options to custom header functions, which will allow customers that use custom header functions to access request information to sign their requests cryptographically. Request options are available when 1) generating the API client, 2) executing individual model operations, and 3) when creating subscriptions.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.