(GH-actions) add allow-licenses list in dependency_review #PR2
#12615
Conversation
kvramyasri7
changed the title
kvramyasri7
changed the title
There was a problem hiding this comment.
Thanks for adding this in @kvramyasri7
Added a comment regarding removing existing license-test workflow
I think it'll be great to also get an approval from product for the acceptable licenses listed in dependecy-review-config.yml just in case
| allow-licenses: | ||
| - '0BSD' | ||
| - 'Apache-2.0' | ||
| - 'BSL-1.0' | ||
| - 'BSD-1-Clause' | ||
| - 'BSD-2-Clause-FreeBSD' | ||
| - 'BSD-2-Clause' | ||
| - 'BSD-3-Clause-Attribution' | ||
| - 'BSD-3-Clause' | ||
| - 'BSD-Source-Code' | ||
| - 'bzip2-1.0.6' | ||
| - 'CC-BY-3.0' | ||
| - 'CC-BY-4.0' | ||
| - 'CC0-1.0' | ||
| - 'curl' | ||
| - 'ISC' | ||
| - 'JSON' | ||
| - 'MIT' | ||
| - 'MPL-2.0' | ||
| - 'NTP' | ||
| - 'OFL-1.0' | ||
| - 'OLDAP-2.8' | ||
| - 'OpenSSL' | ||
| - 'PDDL-1.0' | ||
| - 'PostgreSQL' | ||
| - 'Python-2.0' | ||
| - 'Spencer-94' | ||
| - 'Unicode-DFS-2015' | ||
| - 'Unicode-DFS-2016' | ||
| - 'Unlicense' | ||
| - 'WTFPL' | ||
| - 'X11' | ||
| - 'zlib-acknowledgement' | ||
| - 'Zlib' |
There was a problem hiding this comment.
any reason to not what currently UI team has https://github.com/aws-amplify/amplify-ui/blob/main/.github/dependency-review/config.yml ?
There was a problem hiding this comment.
from the conversation I had with one of the engineer from ui team, this list is subjected to change. Referencing the latest guide from oss is the tip I had.
There was a problem hiding this comment.
I have updated the license list to Amazon pre-approved list @elorzafe. Please take a look at it now. If you find something that should not be in the list let me know we can chat with the people who made the list and communicate with ui-team as well.
| @@ -0,0 +1,27 @@ | |||
| allow-licenses: | |||
| - '0BSD' | |||
There was a problem hiding this comment.
I couldnt find this on the pre approved list
There was a problem hiding this comment.
I have doubts on the following licences:
0BSDBSDshow can we verify if it has PATENTSMPL-2.0OLDAP-2.8it seems the approved isOpenLDAP 2.6.6Unicode-DFS-2015andUnicode-DFS-2016
we can verify these with a ticket to osa and also would appreciate @ovalba
|
@ovalba I would like your feedback on this. Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kvramyasri7
changed the title
kvramyasri7
changed the title
allow-licenses list in dependency_review #PR2
Description of changes
add
allow-licenseslist in dependency_review.Used them as a source of truth:
for checking the list of licenses.
Issue #, if available
Description of how you validated changes
aws-amplify/amplify-ui#4145 Took this as reference PR from sibling team.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.