feat(core): update detectable user agent for getClientInfo #12661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadetastic
reviewed
Dec 1, 2023
|
|
||
| import { getClientInfo } from '../../../src/utils/getClientInfo/getClientInfo'; | ||
|
|
||
| const testCases: [string, string, object][] = [ |
There was a problem hiding this comment.
Q: Would it be helpful to use this API (or something similar) to keep this test case up to date automatically?
There was a problem hiding this comment.
Could add this as a canary test item.
cshfang
previously approved these changes
Dec 1, 2023
packages/core/__tests__/utils/getClientInfo/getClientInfo.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/utils/getClientInfo/getClientInfo.test.ts
Outdated
Show resolved
Hide resolved
|
|
||
| import { getClientInfo } from '../../../src/utils/getClientInfo/getClientInfo'; | ||
|
|
||
| const testCases: [string, string, object][] = [ |
There was a problem hiding this comment.
Nit: Move to some testUtils/testCases.ts file?
There was a problem hiding this comment.
These test cases are tight to this particular suite, I don't think it will be reused elsewhere... keeping inline should be fine? 😅
HuiSF
force-pushed
the
hui/feat/core/update-ua-detection
branch
from
6bbe415
to
a4f1f41
Compare
cshfang
approved these changes
Dec 4, 2023
jimblanc
approved these changes
Dec 5, 2023
HuiSF
force-pushed
the
hui/feat/core/update-ua-detection
branch
from
a4f1f41
to
c855ef5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
#12650
Description of how you validated changes
Update the regular expressions for detecting user agent.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.