Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): upgrade action node version to 18 #12695

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Dec 12, 2023

Description of changes

Requires: https://github.com/aws-amplify/amplify-js-samples-staging/pull/754

Issue #, if available

Description of how you validated changes

CI Checks sample: https://github.com/aws-amplify/amplify-js/actions/runs/7174539999

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners December 12, 2023 00:27
Copy link

⚠️ This PR includes manual changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not modify "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library.

A repository administrator is required to review & merge this change.

@HuiSF HuiSF force-pushed the hui/chore/repo/upgrade-node-18 branch 2 times, most recently from 2c8adf3 to 9f8df8d Compare December 12, 2023 23:17
kvramyasri7
kvramyasri7 previously approved these changes Dec 13, 2023
@HuiSF HuiSF force-pushed the hui/chore/repo/upgrade-node-18 branch from 9f8df8d to 2f21d66 Compare December 13, 2023 20:37
@HuiSF HuiSF merged commit 30f1a3a into main Dec 13, 2023
30 checks passed
@HuiSF HuiSF deleted the hui/chore/repo/upgrade-node-18 branch December 13, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants