Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): get redirectUri before setting oauth keys #12700

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

israx
Copy link
Contributor

@israx israx commented Dec 12, 2023

Description of changes

This change will prevent to set oauth keys if there is an error while getting the redirectUri

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@israx israx requested a review from a team as a code owner December 12, 2023 19:54
@israx israx changed the title chore: get redirectUri before setting oauth keys chore(auth): get redirectUri before setting oauth keys Dec 12, 2023
@israx israx merged commit 9ad889a into aws-amplify:main Dec 12, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants