Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): jest heap usage #12706

Merged
merged 2 commits into from
Dec 15, 2023
Merged

chore(repo): jest heap usage #12706

merged 2 commits into from
Dec 15, 2023

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Dec 14, 2023

Description of changes

  • Broke down the Datastore.test suite into 3 suites to avoid jest heap out of memory
  • Enabled --logHeapUsage for jest runs to monitor the heap sizes used running tests

For Datastore.test:

  • Original heap size: ~3.7GB
  • After broke down the test suite:
    • Datastore.test: ~880MB
    • DataStore.CustomPrimaryKey.test: ~1.4GB
    • DataStore.BasicOperations.test: ~1.3GB
    • DataStore.TypeDefinitions.test: ~620MB

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners December 14, 2023 17:25
Copy link

⚠️ This PR includes manual changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not modify "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library.

A repository administrator is required to review & merge this change.

1 similar comment
Copy link

⚠️ This PR includes manual changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not modify "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library.

A repository administrator is required to review & merge this change.

Copy link
Contributor

@svidgen svidgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look OK on spot check. And the bottom line adds up:

Tests:       14 skipped, 1116 passed, 1130 total

Thanks!

@jimblanc jimblanc merged commit fd0c6d8 into main Dec 15, 2023
30 of 31 checks passed
@HuiSF HuiSF deleted the hui/fix/datastore/test-heap branch December 18, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants