feat(core): queued storage (react-native) for logger #12798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
8677a78
to
61cd97f
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage
branch
from
912924f
to
38e0351
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
61cd97f
to
74d99c3
Compare
jimblanc
previously approved these changes
Jan 8, 2024
HuiSF
force-pushed
the
hui/feat/core/queued-storage
branch
from
38e0351
to
e89ef1f
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
74d99c3
to
e77ccab
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage
branch
from
e89ef1f
to
f359840
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
e77ccab
to
d0b5c9a
Compare
AllanZhengYP
previously approved these changes
Jan 9, 2024
ashwinkumar6
previously approved these changes
Jan 10, 2024
|
|
||
| const getQueuedItemKeys = async ( | ||
| as: ReturnType<typeof loadAsyncStorage>, | ||
| sortKeys: boolean = false |
There was a problem hiding this comment.
nit QQ
I think performance wise it's faster if we aren't manually sorting hence we default to false.
But I'm wondering if when this is used by CW, we'd always set this to true to make sure the older logs get a chance first
There was a problem hiding this comment.
Enable sortKeys is less performant actually, it should only be used when there is a need, for example, get first N items from the queue. So made it an opt-in option here. Feel free to change though as this is an internal util.
| const testBytesSize = 1; | ||
| const mockKeys = [`${keyPrefix}_key1`, `${keyPrefix}_key2`]; | ||
| const mockQueuedItems = [ | ||
| { |
There was a problem hiding this comment.
nit QQ
Is it possible the store might have other keys as well (without db prefix)
should we add a test wit those keys as well and check if
- those keys aren't getting updated/deleted.
- those keys getting changed don't have an impact on total currentBytesSize
There was a problem hiding this comment.
These items should've been covered with the test suites in this PR.
| } from '../../../src/utils/queuedStorage/createQueuedStorage.native'; | ||
| import { ItemToAdd, QueuedItem } from '../../../src/utils/queuedStorage/types'; | ||
| import { getAddItemBytesSize } from '../../../src/utils/queuedStorage/getAddItemBytesSize'; | ||
|
|
HuiSF
force-pushed
the
hui/feat/core/queued-storage
branch
from
f359840
to
5596896
Compare
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
d0b5c9a
to
a160870
Compare
HuiSF
dismissed stale reviews from ashwinkumar6, AllanZhengYP, and jimblanc
The base branch was changed.
HuiSF
force-pushed
the
hui/feat/core/queued-storage-rn
branch
from
a160870
to
e8d6212
Compare
ashwinkumar6
approved these changes
Jan 10, 2024
jimblanc
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implementation of the queued storage for react-native.
Depends on #12791
NOTE: Please do NOT click the update branch button.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.