fix(auth): improve error handling while refreshing auth tokens #12802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }); | ||
|
|
||
| describe('negative cases', () => { |
There was a problem hiding this comment.
In all the test cases, should we checking for the failure hub event to be dispatched as well along with the throwing of the error?
There was a problem hiding this comment.
the refreshToken doesn't dispatches hub events. Probably we can test that use case in the token orchestrator
Samaritan1011001
previously approved these changes
Jan 5, 2024
ashika112
reviewed
Jan 5, 2024
| @@ -384,7 +384,7 @@ | |||
| "name": "[Auth] confirmSignIn (Cognito)", | |||
| "path": "./dist/esm/auth/index.mjs", | |||
| "import": "{ confirmSignIn }", | |||
| "limit": "25.70 kB" | |||
| "limit": "25.89 kB" | |||
There was a problem hiding this comment.
Question: why are we increasing the limits in this PR?
There was a problem hiding this comment.
some APIs depend on fetchAuthSession and adding additional code to that API might result in a bundle size bump
israx
dismissed stale reviews from jimblanc, ashika112, and Samaritan1011001
via
78341ac
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
jimblanc
approved these changes
Jan 8, 2024
ashika112
approved these changes
Jan 8, 2024
Samaritan1011001
approved these changes
Jan 8, 2024
elorzafe
reviewed
Jan 11, 2024
| @@ -113,3 +127,16 @@ export interface OAuthStore { | |||
| clearOAuthInflightData(): Promise<void>; | |||
| clearOAuthData(): Promise<void>; | |||
| } | |||
| function isAuthenticated(tokens?: CognitoAuthTokens | null) { | |||
| return tokens?.accessToken && tokens?.idToken; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Main changes:
implicit grantoauth flow.tokenRefresh_failureevent when the refresh_token is expired.Issue #, if available
Description of how you validated changes
refresh_tokenin the Cognito console and was able to see that therefreshToken_failureevent was dispatchedChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.