Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix canary tests #12821

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

ashwinkumar6
Copy link
Contributor

@ashwinkumar6 ashwinkumar6 commented Jan 9, 2024

Description of changes

  • canary e2e tests
    • comment canary tests integ_angular_auth_angular_authenticator and integ_javascript_auth. These tests are commented on V6 e2e as well
  • canary sampleapp tests
    • comment samples/angular/interactions/new-angular-app (commented in V6 e2e). No V6 angular e2e tests to replace this with.
    • comment samples/vue/auth/authenticator-vue3 (commented in V6 e2e). No V6 vue e2e tests to replace this with.
    • replace samples/javascript/auth/auth-cdn (commented in V6 e2e) with samples/javascript/datastore/new-javascript-app. Replaced with another vanilla javascript test

Description of how you validated changes

CI run with these changes 馃煝

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner January 9, 2024 23:52
@ashwinkumar6 ashwinkumar6 merged commit 59a4aef into aws-amplify:main Jan 11, 2024
30 checks passed
@ashwinkumar6 ashwinkumar6 deleted the fix-failing-canary branch January 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants