fix(api-graphql): server side iam auth mode is ineffective #12992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/fix/api-graphql/server-side-iam
branch
from
05a2f3a
to
c99632c
Compare
HuiSF
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
HuiSF
commented
Feb 9, 2024
There was a problem hiding this comment.
@AllanZhengYP Please review this, ty!
There was a problem hiding this comment.
Thanks! What's the difference of this change v.s. using the server version of internal post? https://github.com/aws-amplify/amplify-js/blob/hui/fix/api-graphql/server-side-iam/packages/api-rest/src/internals/server.ts
There was a problem hiding this comment.
GQL impl. doesn't pick the client vs server versions, it just passing the Amplify instances down into the post API.
HuiSF
force-pushed
the
hui/fix/api-graphql/server-side-iam
branch
from
c99632c
to
9870bb5
Compare
HuiSF
force-pushed
the
hui/fix/api-graphql/server-side-iam
branch
from
9870bb5
to
0b189ca
Compare
AllanZhengYP
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
The internal POST handler part of change looks good to me! Thank you @HuiSF
svidgen
approved these changes
Feb 13, 2024
stocaaro
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
postfunction for api-graphql to make it server side usable (can inject the instance ofAmplifyClassV6from the server context)graphqlmethodwrapperimplementation to ensure it's anawait-able function so Amplify server context can ensure destroying context only after this function has completedIssue #, if available
#12984
#12931
#12867
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.