Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-amplify): enable eslint and remove tslint #13002

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Feb 12, 2024

Description of changes

  • removed tslint and enabled eslint for packages/aws-amplify
  • run yarn lint:fix to automatically fix linter reported issues
  • no manual fix was required for linter issues.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners February 12, 2024 21:44
Copy link

⚠️ This PR includes manual changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not modify "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library.

A repository administrator is required to review & merge this change.

cshfang
cshfang previously approved these changes Feb 13, 2024
ashika112
ashika112 previously approved these changes Feb 13, 2024
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding extra space here and elsewhere
helpful 😅

jimblanc
jimblanc previously approved these changes Feb 13, 2024
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

elorzafe
elorzafe previously approved these changes Feb 13, 2024
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/eslint branch from 0a5ae05 to 4a43191 Compare February 14, 2024 01:29
@HuiSF HuiSF dismissed stale reviews from ashika112, elorzafe, and jimblanc via bf33635 February 15, 2024 16:38
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/eslint branch from 4a43191 to bf33635 Compare February 15, 2024 16:38
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/eslint branch from bf33635 to eca1c31 Compare February 15, 2024 17:08
@HuiSF HuiSF merged commit 504c082 into main Feb 15, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/chore/aws-amplify/eslint branch February 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants