chore(storage): enable eslint and remove tslint #13004
Conversation
.eslintrc.js
Outdated
| @@ -55,7 +55,7 @@ module.exports = { | |||
| 'react-native', | |||
| 'rtn-push-notification', | |||
| 'rtn-web-browser', | |||
| 'storage', | |||
| // 'storage', | |||
There was a problem hiding this comment.
Why not just delete this?
There was a problem hiding this comment.
Meant to delete everything et the end to avoid merge conflicts (if it really helped...)
| // TODO(eslint): remove this linter suppression. | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment |
There was a problem hiding this comment.
Do we want to address this in this PR?
There was a problem hiding this comment.
I had the same question when this code is introduced...
There is no solution here as we can mutating the typescript thought "readonly" property. We can use as any here to remove the lint error though...
| import { parseXmlError } from './utils'; | ||
|
|
||
| const DOMAIN_PATTERN = /^[a-z0-9][a-z0-9\.\-]{1,61}[a-z0-9]$/; | ||
| const DOMAIN_PATTERN = /^[a-z0-9][a-z0-9.-]{1,61}[a-z0-9]$/; |
There was a problem hiding this comment.
Isn't this a logic change from specifically a period to any character?
There was a problem hiding this comment.
Note that the . special char is in the character class [].
Inside a character class, the dot loses its special meaning and matches a literal dot.
So it matches the dot . specifically, not any single char, i.e. the escape slash is redundant (and \ cannot appear in a domain, so it's not the case trying to match a \ char either)
| return; | ||
| } | ||
| // TODO(eslint): remove this linter suppression. |
HuiSF
force-pushed
the
hui/chore/storage/eslint
branch
3 times, most recently
from
97bf5b4
to
6a92a05
Compare
HuiSF
force-pushed
the
hui/chore/storage/eslint
branch
from
6a92a05
to
13abd6e
Compare
HuiSF
force-pushed
the
hui/chore/storage/eslint
branch
2 times, most recently
from
7e72858
to
2e9c5d7
Compare
HuiSF
force-pushed
the
hui/chore/storage/eslint
branch
from
c3626a8
to
99bca3d
Compare
Description of changes
See each commit message for details of changes.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.