Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/migrate analytics to eslint #13007

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

cshfang
Copy link
Contributor

@cshfang cshfang commented Feb 13, 2024

Description of changes

This PR migrates the Analytics linting from tslint to eslint. This PR is broken up into discrete commits:

  1. Enabling ESLint and removing TSLint
  2. Allowing ESLint to autofix issues via yarn lint:fix
  3. Manually fixing found issues that were not auto-correctable

Description of how you validated changes

yarn test

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang requested a review from a team as a code owner February 13, 2024 16:29
HuiSF
HuiSF previously approved these changes Feb 13, 2024
ashika112
ashika112 previously approved these changes Feb 13, 2024
jimblanc
jimblanc previously approved these changes Feb 14, 2024
@cshfang cshfang dismissed stale reviews from jimblanc and ashika112 via 354071a February 14, 2024 23:59
@cshfang cshfang merged commit 9ebb54a into aws-amplify:main Feb 15, 2024
30 checks passed
@cshfang cshfang deleted the chore/migrate-analytics-to-eslint branch February 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants