chore(repo): update eslint ignore rule to be specific to packages #13010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
previously approved these changes
Feb 13, 2024
jimblanc
approved these changes
Feb 13, 2024
cshfang
approved these changes
Feb 14, 2024
ashika112
reviewed
Feb 14, 2024
| if (this.authOptions?.credentialsProvider) { | ||
| return await this.authOptions.credentialsProvider.clearCredentialsAndIdentityId(); | ||
| } | ||
| await this.authOptions?.credentialsProvider?.clearCredentialsAndIdentityId(); |
There was a problem hiding this comment.
Nit: I prefer the old version. Its more explicit and easily readable :)
There was a problem hiding this comment.
But I prefer the latest as the new/upgraded versions includes security patches. But thanks for the suggestion will keep in mind.
ashika112
reviewed
Feb 14, 2024
|
|
||
| function assertUserPoolAndIdentityPoolConfig( |
There was a problem hiding this comment.
Should this have been removed or properly used somewhere? I see its un used at the moment.
ashika112
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
corepackage again to conform to the linter rules.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.