build: remove wml dependency #13014
Merged
build: remove wml dependency #13014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elorzafe
previously approved these changes
Feb 14, 2024
jimblanc
reviewed
Feb 14, 2024
package.json
Outdated
| @@ -126,7 +125,6 @@ | |||
| "webpack": "^5.75.0", | |||
| "webpack-bundle-analyzer": "^4.7.0", | |||
| "webpack-cli": "^5.0.0", | |||
| "wml": "0.0.83", | |||
| "winston": "3.11.0" | |||
There was a problem hiding this comment.
I think we can remove winston as well now, which was introduced here: 768788d
kvramyasri7
previously approved these changes
Feb 14, 2024
kvramyasri7
reviewed
Feb 14, 2024
| @@ -103,6 +103,8 @@ yarn run test --scope @aws-amplify/auth | |||
| **Yarn Linking** | |||
| The best way to develop locally and test is to link the individual package you’re working on and run lerna in watch mode. | |||
|
|
|||
| Note: to test using the react-native framework you will need to use [Verdaccio](#verdaccio) | |||
There was a problem hiding this comment.
just a nit you can ignore as well not requesting for changes 😅
Suggested change
| Note: to test using the react-native framework you will need to use [Verdaccio](#verdaccio) | |
| Note: to test using the react-native framework you will have to use [Verdaccio](#verdaccio) |
jimblanc
previously approved these changes
Feb 14, 2024
kvramyasri7
previously approved these changes
Feb 14, 2024
There was a problem hiding this comment.
I am approving but if you need @Samaritan1011001 approval we can wait. But giving my approval
Samaritan1011001
previously approved these changes
Feb 14, 2024
cshfang
previously approved these changes
Feb 14, 2024
erinleigh90
dismissed stale reviews from kvramyasri7, Samaritan1011001, cshfang, and jimblanc
via
8a09b5c
jimblanc
approved these changes
Feb 16, 2024
ashika112
approved these changes
Feb 16, 2024
kvramyasri7
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes wml dependency and react-native development script. Updates CONTRIBUTING guide to direct developers to test ReactNative using Verdaccio.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.