-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Export fetchAuthSession input & output types #13037
Conversation
…js into chore/export-fas-types
…js into chore/export-fas-types
export const fetchAuthSession = (options?: FetchAuthSessionOptions) => { | ||
export const fetchAuthSession = ( | ||
options?: FetchAuthSessionOptions, | ||
): Promise<AuthSession> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the return type here more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we confirm is there is a test for this use case also probably type those too? What are your thoughts?
The Amplify Auth package has come a long way with the V6 upgrade, it's great to see. For the sake of consistency, perhaps this PR should also add a
Perhaps |
Description of changes
Export the
fetchAuthSession
input & output types fromaws-amplify/auth
, in line with our other v6 APIs.Issue #, if available
Description of how you validated changes
Local testing
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.