Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Prefix resolver & Path input validation #13113

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Feat: Prefix resolver & Path input validation #13113

merged 4 commits into from
Mar 14, 2024

Conversation

ashika112
Copy link
Contributor

@ashika112 ashika112 commented Mar 12, 2024 •
edited
Loading

Description of changes

  • Adds deprecation warning for prefix resolver
  • Adds validation on path parameter in input

Description of how you validated changes

  • Unit tests
  • Manual Validation in sample app

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika112 ashika112 changed the title add deprecation warning Feat: Prefix resolver deprecation warning Mar 12, 2024
@ashika112 ashika112 marked this pull request as ready for review March 13, 2024 18:23
@ashika112 ashika112 requested review from a team as code owners March 13, 2024 18:23
@ashika112 ashika112 changed the title Feat: Prefix resolver deprecation warning Feat: Prefix resolver & Path input validation Mar 13, 2024
@ashika112 ashika112 requested a review from a team as a code owner March 13, 2024 18:50
erinleigh90
erinleigh90 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@erinleigh90 erinleigh90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kvramyasri7
kvramyasri7 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@kvramyasri7 kvramyasri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work AshIKA, Thanks for putting this together ✌🎈

ashwinkumar6
ashwinkumar6 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ashwinkumar6 ashwinkumar6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !!
lgtm

@ashika112 ashika112 merged commit ac87369 into aws-amplify:gen2-storage Mar 14, 2024
26 of 28 checks passed
@ashika112 ashika112 deleted the feat/gen2-prefix-resolver branch March 14, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

@kvramyasri7 kvramyasri7 kvramyasri7 approved these changes

@erinleigh90 erinleigh90 erinleigh90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashika112 @ashwinkumar6 @kvramyasri7 @erinleigh90