feat(api-graphql): alias authMode identityPool -> iam #13299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
reviewed
Apr 26, 2024
| @@ -82,6 +82,7 @@ export type GraphQLAuthMode = | |||
| | 'oidc' | |||
| | 'userPool' | |||
| | 'iam' | |||
There was a problem hiding this comment.
Should we start marking iam as @deprecated so we can remove it from the next major version?
There was a problem hiding this comment.
I tried that, but it doesn't actually surface over union types AFAICT
There was a problem hiding this comment.
Maybe still worth it as a reminder to ourselves. I'll update
svidgen
previously approved these changes
Apr 26, 2024
svidgen
approved these changes
Apr 26, 2024
HuiSF
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
authMode: 'identityPool', which is an alias for'iam'Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.