Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 image fix #133

Merged
merged 4 commits into from
Jan 17, 2018
Merged

S3 image fix #133

merged 4 commits into from
Jan 17, 2018

Conversation

powerful23
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          51       51           
  Lines        2297     2297           
  Branches      461      461           
=======================================
  Hits         2114     2114           
  Misses        174      174           
  Partials        9        9
Impacted Files Coverage Δ
packages/aws-amplify-react/src/Storage/S3Album.js 94.05% <100%> (ø) ⬆️
packages/aws-amplify-react/src/Storage/S3Image.js 96.49% <100%> (ø) ⬆️
packages/aws-amplify-react/src/Storage/S3Text.js 91.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e235705...1cdf05a. Read the comment docs.

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit 635bd5a into aws-amplify:master Jan 17, 2018
@powerful23 powerful23 deleted the s3_image_fix branch January 18, 2018 17:54
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants