fix(core|auth|adapterCore): use createAuthTokenRefresher #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
reviewed
May 17, 2024
.../aws-amplify/src/adapter-core/authProvidersFactories/cognito/createUserPoolsTokenProvider.ts
Outdated
Show resolved
Hide resolved
.../aws-amplify/src/adapter-core/authProvidersFactories/cognito/createUserPoolsTokenProvider.ts
Outdated
Show resolved
Hide resolved
HuiSF
force-pushed
the
hui/fix/ssr-deduped-token-refresher
branch
5 times, most recently
from
d05b48f
to
cbf45ab
Compare
HuiSF
changed the title
HuiSF
force-pushed
the
hui/fix/ssr-deduped-token-refresher
branch
from
cbf45ab
to
f0f8d8c
Compare
cshfang
reviewed
May 17, 2024
...fy/__tests__/adapterCore/authProvidersFactories/cognito/createUserPoolsTokenProvider.test.ts
Outdated
Show resolved
Hide resolved
HuiSF
force-pushed
the
hui/fix/ssr-deduped-token-refresher
branch
from
f0f8d8c
to
2de2895
Compare
Now we are using the createAuthTokenRefresher for creating new instances of the deduped token refresher function for different use cases: 1. on client: there is only one instance gets created on app load 2. on server: a new instance gets created in each context that's created by runWithAmplifySeverContext function
HuiSF
force-pushed
the
hui/fix/ssr-deduped-token-refresher
branch
from
2de2895
to
dd5cab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.