fix: pin node version in gh actions #13450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
approved these changes
May 30, 2024
israx
approved these changes
May 30, 2024
ashika112
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pins the version of Node expected in e2e integ test setup. npm-cli-adduser fails with node version 18.20.3.
Issue #, if available
Description of how you validated changes
Reproduced error locally with node version 18.20.3 and validated that the error did not show up when using earlier versions of node. Pinned node version in my forked repository resulting in this test run in which e2e tests are failing: https://github.com/erinleigh90/amplify-js/actions/runs/9309095374
Note that in the test run above there is an unrelated unit test failure which was not impacted by this change: it was failing before and after pinning node and is not failing in the main repository, so I believe this is unrelated.
yarn testpasses locally.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.