Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): run codeql on PRs to release #13460

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ashwinkumar6
Copy link
Contributor

@ashwinkumar6 ashwinkumar6 commented Jun 3, 2024

Description of changes

  • Run codeql on PRs to release. We currently run this on PRs to main but not PRs to release which is used during a hotfix

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner June 3, 2024 23:42
joon-won
joon-won previously approved these changes Jun 4, 2024
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for this change? Wouldn't it be useful to preserve next/main and next/release for our next major version?

@ashwinkumar6
Copy link
Contributor Author

Discussed async, decided to keep the infra for developing a new major version. Updated PR to just some minor cleanup

@ashwinkumar6 ashwinkumar6 changed the title chore(actions): remove next/release, next/main chore(actions): run codeql on PRs to release Jun 4, 2024
@ashwinkumar6 ashwinkumar6 merged commit 322cc48 into aws-amplify:main Jun 6, 2024
30 checks passed
@ashwinkumar6 ashwinkumar6 deleted the clean-action branch June 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants