release(required): Parsing custom oAuth in amplify_outputs #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
commented
Jun 6, 2024
There was a problem hiding this comment.
just lint changes on this file
jimblanc
previously approved these changes
Jun 6, 2024
jimblanc
approved these changes
Jun 6, 2024
israx
reviewed
Jun 6, 2024
svidgen
approved these changes
Jun 6, 2024
Comment on lines
+319
to
+325
| return providers.reduce<OAuthProvider[]>((oAuthProviders, provider) => { | ||
| if (providerNames[provider] !== undefined) { | ||
| oAuthProviders.push(providerNames[provider]); | ||
| } | ||
|
|
||
| return oAuthProviders; | ||
| }, []); |
There was a problem hiding this comment.
Essentially this?
Suggested change
| return providers.reduce<OAuthProvider[]>((oAuthProviders, provider) => { | |
| if (providerNames[provider] !== undefined) { | |
| oAuthProviders.push(providerNames[provider]); | |
| } | |
| return oAuthProviders; | |
| }, []); | |
| return providers.map(provider => providerNames[provider]).filter(p => p); |
There was a problem hiding this comment.
yes ! reduce reduces the two iteration :P
calebpollman
reviewed
Jun 6, 2024
Comment on lines
+319
to
+325
| return providers.reduce<OAuthProvider[]>((oAuthProviders, provider) => { | ||
| if (providerNames[provider] !== undefined) { | ||
| oAuthProviders.push(providerNames[provider]); | ||
| } | ||
|
|
||
| return oAuthProviders; | ||
| }, []); |
There was a problem hiding this comment.
Can simplify this with filter:
Suggested change
| return providers.reduce<OAuthProvider[]>((oAuthProviders, provider) => { | |
| if (providerNames[provider] !== undefined) { | |
| oAuthProviders.push(providerNames[provider]); | |
| } | |
| return oAuthProviders; | |
| }, []); | |
| return providers.filter(provider => !!providerNames[provider]); |
There was a problem hiding this comment.
slight note we would need map and filter in this case :P
calebpollman
approved these changes
Jun 6, 2024
israx
added a commit
that referenced
this pull request
Jun 7, 2024
* release(required): Parsing custom oAuth in amplify_outputs (#13474) * update parseAmplify logic * revert custom oAuth from gen1 config * update bundle size * chore(release): Publish [skip release] - @aws-amplify/adapter-nextjs@1.2.3 - @aws-amplify/analytics@7.0.35 - @aws-amplify/api@6.0.37 - @aws-amplify/api-graphql@4.1.6 - @aws-amplify/api-rest@4.0.35 - @aws-amplify/auth@6.3.5 - aws-amplify@6.3.6 - @aws-amplify/core@6.3.2 - @aws-amplify/datastore@5.0.37 - @aws-amplify/datastore-storage-adapter@2.1.37 - @aws-amplify/geo@3.0.35 - @aws-amplify/interactions@6.0.34 - @aws-amplify/notifications@2.0.35 - @aws-amplify/predictions@6.1.10 - @aws-amplify/pubsub@6.1.9 - @aws-amplify/storage@6.4.6 - tsc-compliance-test@0.1.39 * chore(release): update API docs [skip release] --------- Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
parseAmplifyOutputsfunction does not take into account any custom oAuth Provider and this lead to providers in oAuth config having undefined values breaking the UI Authenticator component.In additon to the fix for Amplify outputs, the PR loosens up the OAuth config type. Since looking into the issue, realized our parse utility provided for adding custom oAuth as string to list of providers outside of our
CustomProviderinOAuthConfig.Issue #, if available
#13466
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.