Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup custom attr #160

Merged
merged 9 commits into from
Jan 18, 2018
Merged

Conversation

powerful23
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 17, 2018

Codecov Report

Merging #160 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   92.03%   92.09%   +0.05%     
==========================================
  Files          51       51              
  Lines        2297     2314      +17     
  Branches      461      467       +6     
==========================================
+ Hits         2114     2131      +17     
  Misses        174      174              
  Partials        9        9
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 97.28% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635bd5a...05af582. Read the comment docs.

@xpolb01
Copy link

xpolb01 commented Jan 17, 2018

Hi guys! When will this PR be merged? We really need it to move forward with SignUp 🤓

@mlabieniec mlabieniec added this to Icebox in aws-amplify via automation Jan 17, 2018
@mlabieniec mlabieniec moved this from Icebox to Current Sprint in aws-amplify Jan 17, 2018
Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂

@powerful23
Copy link
Contributor Author

for issue #18

@powerful23 powerful23 merged commit be8db91 into aws-amplify:master Jan 18, 2018
aws-amplify automation moved this from Current Sprint to Released Jan 18, 2018
@MatteCarra
Copy link

MatteCarra commented Jan 18, 2018

@powerful23 powerful23 deleted the signup_custom_attr branch January 18, 2018 17:54
@mtstrong17
Copy link

When will this be on NPM?

@mlabieniec
Copy link
Contributor

@mtstrong17 publishing to npm momentarily

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
aws-amplify
  
@beta
Development

Successfully merging this pull request may close these issues.

None yet

6 participants