Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Utils method to check for integer #185

Merged
merged 4 commits into from
Jan 31, 2018
Merged

Add Utils method to check for integer #185

merged 4 commits into from
Jan 31, 2018

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Jan 24, 2018

Hi guys,

I faced the issue with Number.isInteger on IE11 and see that this method is not supported there.
There is a Polyfill available on MDN
so I've added an utils method for checking isInteger.

Please let me know if this makes sense.
Thanks

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #185 into master will decrease coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   90.89%   90.83%   -0.07%     
==========================================
  Files          53       53              
  Lines        2493     2498       +5     
  Branches      504      506       +2     
==========================================
+ Hits         2266     2269       +3     
- Misses        217      219       +2     
  Partials       10       10
Impacted Files Coverage Δ
packages/aws-amplify/src/Cache/StorageCache.ts 78.72% <100%> (ø) ⬆️
packages/aws-amplify/src/Cache/Utils/CacheUtils.ts 81.81% <60%> (-6.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124a66...f9fd82f. Read the comment docs.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @yuyokk Great!

@mlabieniec mlabieniec added this to Backlog in aws-amplify via automation Jan 26, 2018
@mlabieniec mlabieniec merged commit 8cbccd3 into aws-amplify:master Jan 31, 2018
aws-amplify automation moved this from Backlog to Released Jan 31, 2018
@yuyokk yuyokk deleted the polyfill-number-is-integer branch January 31, 2018 18:22
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
aws-amplify
  
@beta
Development

Successfully merging this pull request may close these issues.

None yet

4 participants