Ml/react native #200
Merged
Ml/react native #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into link-cognito-sdk
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 92.24% 90.92% -1.32%
==========================================
Files 52 53 +1
Lines 2424 2480 +56
Branches 486 501 +15
==========================================
+ Hits 2236 2255 +19
- Misses 179 215 +36
- Partials 9 10 +1
Continue to review full report at Codecov.
|
mlabieniec
requested review from
richardzcode,
manueliglesias,
powerful23,
nidsharm and
elorzafe
|
When calling API.get(), An error saying "Refused to set unsafe header "User-Agent" which may be caused by RestClient.ts line 79 |
rasfra
pushed a commit
to epidemicsound/amplify-js
that referenced
this pull request
Mar 11, 2020
* add cognito js lib and update references * update cognito lib * update node version and package deps * update cognito sdk and auth test * update with yarn workspaces and modules * add lint to test * update test cmd * update build cmds * update concurrency with bootstrap * update deps, yarn should use local * add build before test for workspaces * remove package-lock.json * update rn package * update deps on react native * update user attributes * update docs * core change * Update package.json * Adds a podspec for CocoaPods support * update docs with cli instructions * update quick start * update crypto lib for react native and polyfill methods * move core logic to aws-amplify * updates for platform detection * fixes for auth persistence * update user agent in RestClient to use Platform * update readme for PR aws-amplify#201 * only set user-agent on API calls in RN * Remove unused JS call for verifiedContact
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses many duplications of code across aws-amplify-react-native and aws-amplify. The core logic around Authentication, including persistence is now located within aws-amplify and included in aws-amplify-react-native. This also contains updates to the amazon-cognito-identity-js to utilize crypo libraries without the need of the requirement of the aws-sdk. All core logic now resides in aws-amplify, with a new Platform check on the navigator.product to determine if running in React Native (see: facebook/react-native#1331).