Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch interface to API #207

Merged
merged 9 commits into from
Jan 31, 2018
Merged

add patch interface to API #207

merged 9 commits into from
Jan 31, 2018

Conversation

richardzcode
Copy link
Contributor

@richardzcode richardzcode commented Jan 30, 2018 •
edited
Loading

To solve #186

Added .patch method

API.patch(apiName, path, init)
  .then(() => /* success */)
  .catch(() => /* error */)

@codecov-io
Copy link

codecov-io commented Jan 30, 2018 •
edited
Loading

Codecov Report

Merging #207 into master will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   90.92%   90.89%   -0.03%     
==========================================
  Files          53       53              
  Lines        2480     2494      +14     
  Branches      501      504       +3     
==========================================
+ Hits         2255     2267      +12     
- Misses        215      217       +2     
  Partials       10       10
Impacted Files Coverage Δ
packages/aws-amplify/src/Common/Signer.ts 97.33% <100%> (+0.07%) ⬆️
packages/aws-amplify/src/API/RestClient.ts 90.62% <100%> (+0.3%) ⬆️
packages/aws-amplify/src/API/API.ts 86.73% <80%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1eb0ab...72e9c8b. Read the comment docs.

@richardzcode richardzcode changed the title add ajax interface to API so other methods can be called add patch interface to API Jan 30, 2018
@richardzcode
Copy link
Contributor Author

Also added fix from PR #190 since that one has conflicts waiting to be resolved.

So this also addresses #127 and #69

powerful23
powerful23 approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elorzafe
elorzafe previously requested changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just small changes

README.md
@@ -54,7 +54,7 @@ For React Native development, install `aws-amplify-react-native` instead of `aws
npm install aws-amplify-react-native --save
```

Unless you're react-native app was created using [Expo v25.0.0 or greater](https://blog.expo.io/expo-sdk-v25-0-0-is-now-available-714d10a8c3f7), you will need to [link](https://facebook.github.io/react-native/docs/linking-libraries-ios.html) libraries in your project for the Auth module on React Native. Follow the instructions [here](https://github.com/aws/aws-amplify/blob/master/media/quick_start.md#react-native-development).
Unless your react-native app was created using [Expo v25.0.0 or greater](https://blog.expo.io/expo-sdk-v25-0-0-is-now-available-714d10a8c3f7), you will need to [link](https://facebook.github.io/react-native/docs/linking-libraries-ios.html) libraries in your project for the Auth module on React Native. Follow the instructions [here](https://github.com/aws/aws-amplify/blob/master/media/quick_start.md#react-native-development).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions to linking the libraries it would be better to do it here (is pain for customers find the instructions and is something simple to add)

packages/aws-amplify/lib/API/API.d.ts
/**
* Make an patch request
* @param {string} apiName - The api name of the request
* @param {string} path - The path of the request'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just extra remove extra '

packages/aws-amplify/lib/API/API.d.ts
* @param {String} apiName - The api name of the request
* @param {JSON} path - The path of the request'
* @param {string} apiName - The api name of the request
* @param {string} path - The path of the request'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra '

packages/aws-amplify/src/API/API.ts Outdated
* @param {String} apiName - The api name of the request
* @param {JSON} path - The path of the request'
* @param {string} apiName - The api name of the request
* @param {string} path - The path of the request'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra '

@richardzcode richardzcode dismissed elorzafe’s stale review January 31, 2018 01:20

minor wording fixes. Can be done in another PR. Unblock this PR since it contains priority fixes

@richardzcode richardzcode merged commit 7be7470 into aws-amplify:master Jan 31, 2018
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@powerful23 powerful23 powerful23 approved these changes

@elorzafe elorzafe elorzafe left review comments

@mlabieniec mlabieniec Awaiting requested review from mlabieniec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardzcode @codecov-io @powerful23 @elorzafe