Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update MFA typescript interface for CognitoUser #279

Merged
merged 3 commits into from Feb 13, 2018

Conversation

woodcockjosh
Copy link
Contributor

@woodcockjosh woodcockjosh commented Feb 13, 2018

There are some missing and inconsistent typescript interfaces for Cognito that cause compiler warnings when using in TypeScript projects. This will add those interfaces. Solution has been tested and implemented. Please let me know if you have any questions or changes you would like me to make.

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 13, 2018

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          53       53           
  Lines        2516     2516           
  Branches      510      510           
=======================================
  Hits         2284     2284           
  Misses        221      221           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a0f0a...5521101. Read the comment docs.

@mlabieniec mlabieniec merged commit 3281689 into aws-amplify:master Feb 13, 2018
1 check passed
rasfra pushed a commit to epidemicsound/amplify-js that referenced this issue Mar 11, 2020
)

* add and update missing and inconsistent typescript interfaces for CognitoUser

* ignore intellij settings
@github-actions
Copy link

@github-actions github-actions bot commented Jun 12, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants