Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled autocomplete when resetting password for new password field #3976

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Conversation

dabit3
Copy link
Contributor

@dabit3 dabit3 commented Sep 5, 2019

Issue #, if available:
Fixes: #3799

Description of changes:
Added autoComplete field to password input for new password. We should assume that users are not wanting this to be autocompleted.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sammartinez
Copy link
Contributor

@dabit3 Can you make sure your branch is up to date? You have some conflicts on your things

@sammartinez sammartinez self-assigned this Sep 6, 2019
@sammartinez sammartinez self-requested a review September 6, 2019 18:55
@sammartinez sammartinez added the needs-review Used as a label in order to review open PRs label Sep 6, 2019
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-review Used as a label in order to review open PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset issue - chrome autofill
2 participants