Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0 profile image #4329

Merged
merged 7 commits into from Apr 23, 2020
Merged

Conversation

christophgysin
Copy link
Contributor

@christophgysin christophgysin commented Nov 2, 2019

Issue #2466

Description of changes:
Return profile image url for Auth0 authentication provider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

@codecov codecov bot commented Nov 2, 2019

Codecov Report

Merging #4329 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4329   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         197      197           
  Lines       11529    11531    +2     
  Branches     2173     2251   +78     
=======================================
+ Hits         8407     8409    +2     
+ Misses       2971     2951   -20     
- Partials      151      171   +20     
Impacted Files Coverage Δ
.../aws-amplify-react/src/Auth/Provider/withAuth0.tsx 73.75% <100.00%> (+0.67%) ⬆️
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3ba81...c54adac. Read the comment docs.

@alkurop
Copy link

@alkurop alkurop commented Nov 8, 2019

picture should go as one of the attributes.
it's done in Cognito console / User Pools / Federation / Attribute mapping.
Hardcoding it does not seem like a good idea

@christophgysin
Copy link
Contributor Author

@christophgysin christophgysin commented Nov 8, 2019

@alkurop Thanks for your feedback. Did you check the linked issue? This is equivalent to how Google authentication provider is implemented. If you disagree with the issue itself, please add a comment on the issue instead.

Copy link
Contributor

@ericclemmons ericclemmons left a comment

This is looking good!

I had to make a similar update to Auth.ts in #4249:

https://github.com/aws-amplify/amplify-js/pull/4249/files#diff-2967e55987ae9a6ba17fc5eef429a5ca

@elorzafe elorzafe merged commit 38c1be5 into aws-amplify:master Apr 23, 2020
5 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Jun 11, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants