New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth0 profile image #4329
Auth0 profile image #4329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4329 +/- ##
=======================================
Coverage 72.92% 72.92%
=======================================
Files 197 197
Lines 11529 11531 +2
Branches 2173 2251 +78
=======================================
+ Hits 8407 8409 +2
+ Misses 2971 2951 -20
- Partials 151 171 +20
Continue to review full report at Codecov.
|
picture should go as one of the attributes. |
@alkurop Thanks for your feedback. Did you check the linked issue? This is equivalent to how Google authentication provider is implemented. If you disagree with the issue itself, please add a comment on the issue instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good!
I had to make a similar update to Auth.ts
in #4249:
https://github.com/aws-amplify/amplify-js/pull/4249/files#diff-2967e55987ae9a6ba17fc5eef429a5ca
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #2466
Description of changes:
Return profile image url for Auth0 authentication provider.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.