Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export UsernameAttributes enum #5197

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Mar 26, 2020

This change makes it possible to specify the usernameAttribute prop in TypeScript without using any.

Fixes #5196

Description of changes:

Here I've exposed the UsernameAttributes enum as a named export by exposing everything in the common/types.ts file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change makes it possible to specify the usernameAttribute prop in TypeScript without using `any`.
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5197 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5197   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         193      193           
  Lines       11449    11450    +1     
  Branches     2221     2221           
=======================================
+ Hits         8378     8379    +1     
  Misses       2923     2923           
  Partials      148      148           
Impacted Files Coverage Δ
packages/aws-amplify-react/src/Auth/index.tsx 87.50% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f518b...4c791af. Read the comment docs.

@manueliglesias manueliglesias self-assigned this Mar 27, 2020
@manueliglesias manueliglesias added Auth Related to Auth components/category React React related issues TypeScript Related to TypeScript issues labels Mar 27, 2020
@manueliglesias manueliglesias self-requested a review March 27, 2020 02:11
Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @selbekk !

@manueliglesias manueliglesias merged commit 23d8d41 into aws-amplify:master Mar 27, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auth Related to Auth components/category React React related issues TypeScript Related to TypeScript issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UsernameAttributes type isn't exposed
3 participants