Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5275 Setting the identityId properly when read from cache #5280

Merged
merged 1 commit into from Apr 2, 2020

Conversation

Amplifiyer
Copy link
Contributor

Issue #, if available: fixes #5275

Description of changes:

  • Set the identityId properly when reading from cache
  • Remove unnecessary comments
  • Auto version update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer self-assigned this Apr 2, 2020
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #5280 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5280      +/-   ##
==========================================
- Coverage   72.71%   72.71%   -0.01%     
==========================================
  Files         195      195              
  Lines       11465    11466       +1     
  Branches     2157     2157              
==========================================
  Hits         8337     8337              
- Misses       2978     2979       +1     
  Partials      150      150              
Impacted Files Coverage Δ
packages/core/src/Credentials.ts 31.62% <0.00%> (-0.15%) ⬇️
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82c511...fb3f69a. Read the comment docs.

@Amplifiyer Amplifiyer merged commit 3c2e2a0 into master Apr 2, 2020
@Amplifiyer Amplifiyer deleted the modularization_patch_5275 branch April 2, 2020 22:55
@mllrmat
Copy link

mllrmat commented Apr 27, 2020

I am still seeing this issue with the latest version. My usecase in React Native: I login with google and make Auth.federatedSignIn(). An the next start of the app the user is authenticated, but missing the identityId.

@bernhardt1
Copy link

I'm also still seeing this issue with latest version. @mllrmat did you find any solution?

@ENRAG3DCHICKEN
Copy link

This wasn't really fixed was it?

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdentityId undefined
6 participants