New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5275 Setting the identityId properly when read from cache #5280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
Codecov Report
@@ Coverage Diff @@
## master #5280 +/- ##
==========================================
- Coverage 72.71% 72.71% -0.01%
==========================================
Files 195 195
Lines 11465 11466 +1
Branches 2157 2157
==========================================
Hits 8337 8337
- Misses 2978 2979 +1
Partials 150 150
Continue to review full report at Codecov.
|
I am still seeing this issue with the latest version. My usecase in React Native: I login with google and make Auth.federatedSignIn(). An the next start of the app the user is authenticated, but missing the identityId. |
I'm also still seeing this issue with latest version. @mllrmat did you find any solution? |
This wasn't really fixed was it? |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: fixes #5275
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.