Make all the strings in amplify-forgot-password translatable #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5771 +/- ##
=======================================
Coverage 73.72% 73.72%
=======================================
Files 203 203
Lines 11944 11944
Branches 2244 2244
=======================================
Hits 8806 8806
Misses 2976 2976
Partials 162 162 Continue to review full report at Codecov.
|
…-in-password-reset
jordanranz
approved these changes
May 14, 2020
…-in-password-reset
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Our project uses Finnish translations with the app and noticed that in the amplify-forgot-password some of the texts were not utilizing the Translations enum. I simply updated the code to utilize these instead of static strings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.