Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for opened notifications in iOS #5835

Merged

Conversation

Ashish-Nanda
Copy link
Contributor

Description of changes:
Adding support for opened notifications in iOS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #5835 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5835   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files         204      204           
  Lines       11973    11973           
  Branches     2342     2254   -88     
=======================================
  Hits         8831     8831           
- Misses       2960     2980   +20     
+ Partials      182      162   -20     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 49.64% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24eb104...89983a8. Read the comment docs.

@Ashish-Nanda Ashish-Nanda marked this pull request as ready for review May 21, 2020 02:50
@sammartinez sammartinez added Push Notifications Related to Push Notification components needs-review Used as a label in order to review open PRs labels May 21, 2020
Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and was able to receive onNotificationOpened callback both when the app is in the background as well as completely killed 👍

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ashish-Nanda Ashish-Nanda merged commit 3b2ec1b into aws-amplify:master May 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-review Used as a label in order to review open PRs Push Notifications Related to Push Notification components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants