Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notification iOS Detox tests #6078

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

amhinson
Copy link
Contributor

Description of changes:
Adds Push Notification Detox tests to CircleCI.

Depends on this sample PR getting merged.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amhinson amhinson requested a review from iartemiev as a code owner June 12, 2020 16:11
@amhinson amhinson self-assigned this Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #6078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6078   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         205      205           
  Lines       12611    12611           
  Branches     2364     2364           
=======================================
  Hits         9267     9267           
  Misses       3181     3181           
  Partials      163      163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd8336...40cbd96. Read the comment docs.

Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amhinson
Copy link
Contributor Author

Just ran this in another testing branch and all the tests passed, so we should be good to go! https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/5345/workflows/a98bbddd-50d4-4c45-a7ee-cde17a65a890

@amhinson amhinson merged commit 67bc430 into aws-amplify:master Jun 16, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants