Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amazon-cognito-identity-js tests to CircleCI #6551

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Conversation

amhinson
Copy link
Contributor

@amhinson amhinson commented Aug 11, 2020

Description of changes:
Add initial amazon-cognito-identity-js integration tests to CircleCI.

Successful test run: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/5785/workflows/af8895dc-9891-4434-be4e-af7d2099321d/jobs/19521


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall if this job runs for PRs (thinking no), but I'm down to merge this once tests pass 🙏

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #6551 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6551   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         208      208           
  Lines       12920    12920           
  Branches     2432     2525   +93     
=======================================
  Hits         9466     9466           
+ Misses       3291     3263   -28     
- Partials      163      191   +28     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 31.67% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.38% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.48% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.69% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1934941...9124164. Read the comment docs.

Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants