Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@aws-amplify/ui-components): v1 ☂️ #7718

Merged
merged 5 commits into from
Feb 15, 2021
Merged

Conversation

ericclemmons
Copy link
Contributor

@ericclemmons ericclemmons commented Feb 9, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #7718 (6d1bed8) into main (e39a71d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7718   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         214      214           
  Lines       13410    13410           
  Branches     2628     2628           
=======================================
  Hits         9934     9934           
  Misses       3277     3277           
  Partials      199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39a71d...6d1bed8. Read the comment docs.

ericclemmons and others added 2 commits February 9, 2021 13:22
This ensures customers including UI components in their projects
won't include duplicate dependencies in development.

Co-authored-by: Sam Martinez <samlmar@amazon.com>
Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
@ericclemmons ericclemmons marked this pull request as ready for review February 11, 2021 17:29
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks @ericclemmons 👍

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@ericclemmons
Copy link
Contributor Author

I'm going to test this merge locally first with Verdaccio to see if it bumps versions as expected.

@ericclemmons ericclemmons changed the title BREAKING: @aws-amplify/ui-components v1 ☂️ chore(@aws-amplify/ui-components): v1 ☂️ Feb 11, 2021
Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ericclemmons ericclemmons changed the title chore(@aws-amplify/ui-components): v1 ☂️ chore(@aws-amplify/ui-components)!: v1 ☂️ Feb 11, 2021
@ericclemmons ericclemmons changed the title chore(@aws-amplify/ui-components)!: v1 ☂️ chore(@aws-amplify/ui-components): v1 ☂️ Feb 11, 2021
@ericclemmons
Copy link
Contributor Author

I updated this PR to explicitly set these packages to 1.0.0. In my testing, because conventional commits rely on the commit message, I have to carefully construct the right format:

https://www.conventionalcommits.org/en/v1.0.0/#summary

So, there's a risk that we squash & commit and it doesn't bump correctly in CI/CD due to user error in the PR title or GitHub process.

Rather than risk it at all, I've explicitly set the versions to 1.0.0. Worst-case scenario, the first release will be 1.0.1. Best-case scenario, lerna will honor the 1.0.0.

@ericclemmons
Copy link
Contributor Author

Alright, I need to see why this build is failing.

I just did a test to see what we'll see:

yarn publish:verdaccio

yarn run v1.22.10
$ lerna publish --no-push --canary minor --dist-tag=unstable --preid=unstable --exact --force-publish --yes

Found 25 packages to publish:
 - amazon-cognito-identity-js => 4.6.0-unstable.6+d1d1e2941
 - @aws-amplify/ui-angular => 0.5.0-unstable.6+d1d1e2941
 - @aws-amplify/ui-components => 0.11.0-unstable.6+d1d1e2941
 - @aws-amplify/ui-react => 0.3.0-unstable.6+d1d1e2941
 - @aws-amplify/ui-vue => 0.4.0-unstable.6+d1d1e2941
 - @aws-amplify/ui => 2.1.0-unstable.537+d1d1e2941
 - @aws-amplify/analytics => 4.1.0-unstable.6+d1d1e2941
 - @aws-amplify/api-graphql => 1.3.0-unstable.6+d1d1e2941
 - @aws-amplify/api-rest => 1.3.0-unstable.6+d1d1e2941
 - @aws-amplify/api => 3.3.0-unstable.6+d1d1e2941
 - @aws-amplify/auth => 3.5.0-unstable.6+d1d1e2941
 - aws-amplify-angular => 5.1.0-unstable.6+d1d1e2941
 - aws-amplify-react-native => 4.4.0-unstable.21+d1d1e2941
 - aws-amplify-react => 4.3.0-unstable.6+d1d1e2941
 - aws-amplify-vue => 2.2.0-unstable.21+d1d1e2941
 - aws-amplify => 3.4.0-unstable.6+d1d1e2941
 - @aws-amplify/cache => 3.2.0-unstable.6+d1d1e2941
 - @aws-amplify/core => 3.9.0-unstable.6+d1d1e2941
 - @aws-amplify/datastore => 2.10.0-unstable.6+d1d1e2941
 - @aws-amplify/interactions => 3.4.0-unstable.6+d1d1e2941
 - @aws-amplify/predictions => 3.3.0-unstable.6+d1d1e2941
 - @aws-amplify/pubsub => 3.3.0-unstable.6+d1d1e2941
 - @aws-amplify/pushnotification => 3.3.0-unstable.6+d1d1e2941
 - @aws-amplify/storage => 3.4.0-unstable.6+d1d1e2941
 - @aws-amplify/xr => 2.3.0-unstable.6+d1d1e2941

yarn publish:release

yarn run v1.22.10
$ lerna publish --conventional-commits --yes --message 'chore(release): Publish [ci skip]'

Changes:
 - @aws-amplify/ui-angular: 1.0.0 => 1.0.1
 - @aws-amplify/ui-components: 1.0.0 => 1.0.1
 - @aws-amplify/ui-react: 1.0.0 => 1.0.1
 - @aws-amplify/ui-storybook: 1.0.0 => 1.0.1 (private)
 - @aws-amplify/ui-vue: 1.0.0 => 1.0.1
 - @aws-amplify/ui-react: 1.0.0 => 1.0.1
 - @aws-amplify/ui-storybook: 1.0.0 => 1.0.1 (private)
 - @aws-amplify/ui-vue: 1.0.0 => 1.0.1
 - @aws-amplify/analytics: 4.0.9 => 4.0.10
 - @aws-amplify/api-graphql: 1.2.21 => 1.2.22
 - @aws-amplify/api-rest: 1.2.21 => 1.2.22
 - @aws-amplify/api: 3.2.21 => 3.2.22
 - @aws-amplify/auth: 3.4.21 => 3.4.22
 - aws-amplify-angular: 5.0.47 => 5.0.48
 - aws-amplify-react: 4.2.22 => 4.2.23
 - aws-amplify: 3.3.18 => 3.3.19
 - @aws-amplify/cache: 3.1.46 => 3.1.47
 - @aws-amplify/core: 3.8.13 => 3.8.14
 - @aws-amplify/datastore: 2.9.7 => 2.9.8
 - @aws-amplify/interactions: 3.3.21 => 3.3.22
 - @aws-amplify/predictions: 3.2.21 => 3.2.22
 - @aws-amplify/pubsub: 3.2.19 => 3.2.20
 - @aws-amplify/pushnotification: 3.2.21 => 3.2.22
 - @aws-amplify/storage: 3.3.21 => 3.3.22
 - @aws-amplify/xr: 2.2.21 => 2.2.22

Successfully published:
 - @aws-amplify/ui-angular@1.0.1
 - @aws-amplify/ui-components@1.0.1
 - @aws-amplify/ui-react@1.0.1
 - @aws-amplify/ui-vue@1.0.1
 - @aws-amplify/analytics@4.0.10
 - @aws-amplify/api-graphql@1.2.22
 - @aws-amplify/api-rest@1.2.22
 - @aws-amplify/api@3.2.22
 - @aws-amplify/auth@3.4.22
 - aws-amplify-angular@5.0.48
 - aws-amplify-react@4.2.23
 - aws-amplify@3.3.19
 - @aws-amplify/cache@3.1.47
 - @aws-amplify/core@3.8.14
 - @aws-amplify/datastore@2.9.8
 - @aws-amplify/interactions@3.3.22
 - @aws-amplify/predictions@3.2.22
 - @aws-amplify/pubsub@3.2.20
 - @aws-amplify/pushnotification@3.2.22
 - @aws-amplify/storage@3.3.22
 - @aws-amplify/xr@2.2.22
...

dgonsan pushed a commit to dgonsan/amplify-js that referenced this pull request Mar 18, 2021
* Support React 17 (aws-amplify#7651)

Co-authored-by: Alex Hinson <alexmhinson@gmail.com>

* Move @aws-amplify/* dependencies to a single peerDependencies (aws-amplify#7650)

This ensures customers including UI components in their projects
won't include duplicate dependencies in development.

Co-authored-by: Sam Martinez <samlmar@amazon.com>
Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>

* Bump @aws-amplify/ui-* to 1.0.0

Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
Co-authored-by: Sam Martinez <samlmar@amazon.com>
Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2022
@jimblanc jimblanc deleted the ui-components-v1 branch November 23, 2022 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants