-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(@aws-amplify/ui-components): v1 ☂️ #7718
Conversation
Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #7718 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 214 214
Lines 13410 13410
Branches 2628 2628
=======================================
Hits 9934 9934
Misses 3277 3277
Partials 199 199 Continue to review full report at Codecov.
|
This ensures customers including UI components in their projects won't include duplicate dependencies in development. Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thanks @ericclemmons 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
I'm going to test this merge locally first with Verdaccio to see if it bumps versions as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I updated this PR to explicitly set these packages to So, there's a risk that we squash & commit and it doesn't bump correctly in CI/CD due to user error in the PR title or GitHub process. Rather than risk it at all, I've explicitly set the versions to |
Alright, I need to see why this build is failing. I just did a test to see what we'll see:
|
d1d1e29
to
6d1bed8
Compare
* Support React 17 (aws-amplify#7651) Co-authored-by: Alex Hinson <alexmhinson@gmail.com> * Move @aws-amplify/* dependencies to a single peerDependencies (aws-amplify#7650) This ensures customers including UI components in their projects won't include duplicate dependencies in development. Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> * Bump @aws-amplify/ui-* to 1.0.0 Co-authored-by: Alex Hinson <alexmhinson@gmail.com> Co-authored-by: Sam Martinez <samlmar@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
fix(@aws-amplify/ui-components): Use dark neutrals rather than Amplify brand colors #7653I'd rather not delay this release because of this nice-to-have change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.