Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to latest version of uuid package. #8953

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

MatrixFrog
Copy link
Contributor

@MatrixFrog MatrixFrog commented Sep 28, 2021

This should eliminate some of the warnings reported in #8464.

Description of how you validated changes

Checklist

  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siegerts siegerts added the first-time-contributor The contribution is the first for this user in the repo label Sep 28, 2021
@MatrixFrog
Copy link
Contributor Author

Not sure why my change would cause this build failure but I'll investigate.

@evcodes evcodes requested review from evcodes and ashika01 and removed request for manueliglesias and iartemiev October 21, 2021 17:24
@ashika01 ashika01 changed the title Upgrade to latest version of uuid package. chore: Upgrade to latest version of uuid package. Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #8953 (5307af8) into main (8c34ddb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8953   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         250      250           
  Lines       18109    18109           
  Branches     3882     3882           
=======================================
  Hits        14129    14129           
  Misses       3850     3850           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c34ddb...5307af8. Read the comment docs.

Copy link
Contributor

@ashika01 ashika01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure was missed rollup config. Thanks for the PR will get this merged in 👍

@ashika01 ashika01 merged commit d7b4f49 into aws-amplify:main Oct 21, 2021
@ashika01 ashika01 mentioned this pull request Oct 21, 2021
2 tasks
@wlee221 wlee221 mentioned this pull request Dec 6, 2021
4 tasks
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor The contribution is the first for this user in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants