Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated dependencies to support installation via Swift Package Manager #1146

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

palpatim
Copy link
Member

@palpatim palpatim commented Apr 6, 2021

Issue #, if available:

Description of changes:

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass (Integ tests run against CocoaPods-managed dependencies, no change)
  • Documentation update for the change if required (Coming in separate PR)
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@palpatim palpatim requested a review from royjit April 6, 2021 23:28
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1146 (17dab06) into main (3f700ac) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   58.97%   58.99%   +0.01%     
==========================================
  Files         652      652              
  Lines       19210    19210              
==========================================
+ Hits        11330    11333       +3     
+ Misses       7880     7877       -3     
Flag Coverage Δ
API_plugin_unit_test 55.66% <ø> (+0.10%) ⬆️
AWSPluginsCore 76.56% <ø> (ø)
Amplify 48.06% <ø> (+0.02%) ⬆️
Analytics_plugin_unit_test 73.41% <ø> (ø)
Auth_plugin_unit_test 82.31% <ø> (ø)
DataStore_plugin_unit_test 73.85% <ø> (ø)
Predictions_plugin_unit_test 33.51% <ø> (ø)
Storage_plugin_unit_test 57.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Amplify/Categories/Hub/HubFilter.swift 57.89% <0.00%> (+5.26%) ⬆️
...lugin/Operation/AWSAPIOperation+APIOperation.swift 83.78% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f700ac...17dab06. Read the comment docs.

@palpatim palpatim merged commit 3dd5f30 into main Apr 6, 2021
@palpatim palpatim deleted the palpatim.feat.update-sdk-deps branch April 6, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants