-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(API): pass authMode used for lazy loading functionality #3690
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
+ Coverage 68.37% 68.52% +0.14%
==========================================
Files 1096 1096
Lines 38089 38120 +31
==========================================
+ Hits 26044 26122 +78
+ Misses 12045 11998 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5013d22
to
0340b52
Compare
@@ -43,7 +46,7 @@ public struct AppSyncListPayload: Codable { | |||
// `GraphQLFilter`. | |||
guard let filterVariablesData = try? encoder.encode(filterValue), | |||
let filterVariablesJSON = try? JSONSerialization.jsonObject(with: filterVariablesData) | |||
as? GraphQLFilter else { | |||
as? [String: Any] else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've reverted it, when i was compiling earlier Xcode wasn't picking up GraphQLFilter properly from AWSPluginsCore. It is working now
Issue #
#3677
Description
Lazy Loading functionality is built on metadata passed to it during decoding. For example, the hasMany list will contain the parent's identifiers and the apiName to reconstruct the request when lazy loading. The belongsTo lazy model will contain its identifiers and the apiName used to when the child model was retrieved.
The issue is with the new
authMode
parameter, theauthMode
was not being passed down to the lazy types (#3677 (comment))General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.