Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datastore): fix broken datastore observeQuery integ tests #3752

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Jun 18, 2024

Issue #

There are several flaky datastore integration tests related to the observeQuery API. The query snapshots are being observed multiple times within the test cases, whereas the assertion should only occur once.

Description

This is expected behavior. During the test case setup, if a new record is created. The subsequent incoming mutation event from the AppSync server (with version 1) will be received, and a snapshot may be triggered by the after-sync listener.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner June 18, 2024 18:23
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 18:24 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:07 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:07 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 18, 2024 21:42 — with GitHub Actions Inactive
@5d 5d merged commit 9ed6c1c into main Jun 19, 2024
191 of 193 checks passed
@5d 5d deleted the 5d/fix-observe-query-integ-test branch June 19, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants