Storage Operation Pause/Resume/Cancel Functionality #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moving some request specific constants over to the request objects (expire time and threshold for multipart upload) - storageError notFound to keyNotFound and missingFile to missingLocalFile
palpatim
reviewed
Sep 20, 2019
AWSPlugins/AWSS3StoragePlugin/Operation/AWSS3StorageDownloadFileOperation.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePlugin/Operation/AWSS3StorageDownloadFileOperation.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePlugin/Request/AWSS3StoragePutRequest.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePluginIntegrationTests/AWSS3StoragePluginResumabilityTests.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePluginIntegrationTests/AWSS3StoragePluginResumabilityTests.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePluginIntegrationTests/AWSS3StoragePluginResumabilityTests.swift
Outdated
Show resolved
Hide resolved
AWSPlugins/AWSS3StoragePluginTests/AWSS3StoragePluginAPIBehaviorTests.swift
Show resolved
Hide resolved
- reduce over checking isCancelled in operations - Adding given when then to integration tests - Split Resumability integration tests and improvements
…peration's pause/resume implementation
lawmicha
changed the title
lawmicha
force-pushed
the
lawmicha/storage
branch
from
21ba77c
to
6b27cbd
Compare
merge master (default hub plugin)
palpatim
reviewed
Sep 24, 2019
AWSPlugins/AWSS3StoragePlugin/Operation/AWSS3StorageDownloadFileOperation.swift
Outdated
Show resolved
Hide resolved
...agePluginIntegrationTests/ResumabilityTests/AWSS3StoragePluginGetDataResumabilityTests.swift
Show resolved
Hide resolved
...agePluginIntegrationTests/ResumabilityTests/AWSS3StoragePluginGetDataResumabilityTests.swift
Outdated
Show resolved
Hide resolved
...agePluginIntegrationTests/ResumabilityTests/AWSS3StoragePluginPutDataResumabilityTests.swift
Show resolved
Hide resolved
palpatim
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.