Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concern, user.storage expose other users idToken, refreshToken, accessToken. #768

Closed
artidataio opened this issue Nov 18, 2021 · 1 comment

Comments

@artidataio
Copy link
Contributor

This has been bugging me for sometime as I have limited knowledge on cyber security especially athentication. I am not sure whether this is the place to ask, but I'll put it here anyway since you guys are pretty responsive. When a user is athenticated, then the browser have access to the user object with keys like username, userPoolId and attributes. This object can be examined easily in React DevTools.

Then there is this storage key in the user object. It contains other users idToken, refreshToken, accessToken. Is it safe for such values to be exposed? Can other users' account get hijacked or jeopardised by knowing such values?

@ericclemmons
Copy link
Contributor

Luckily this has been researched (and debated!) extensively in the Amplify JS repo (which is the underlying client library for the UI):

aws-amplify/amplify-js#3436 (comment)

That would be the best place to continue the discussion 🙏

thaddmt added a commit that referenced this issue Apr 7, 2023
Revert "chore: add debug logs and send them to sample app through hug…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants