Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of amplify-ui 2.0 with Angular 12.2.x fails #806

Closed
fbu-nlstbv opened this issue Nov 19, 2021 · 7 comments
Closed

Installation of amplify-ui 2.0 with Angular 12.2.x fails #806

fbu-nlstbv opened this issue Nov 19, 2021 · 7 comments
Labels
Angular An issue or a feature-request for Angular platform pending-response Issue is pending response from the issue requestor

Comments

@fbu-nlstbv
Copy link

It's not possible to install Amplify UI 2.0 with Angular 12.2.x, see the following command line output:

PS C:\[...]\todo-amp\todo-app-amplify> npm i --save @aws-amplify/ui-angular
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: todo-amp@0.0.0
npm ERR! Found: @angular/common@12.2.13
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.2.13" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.2.4" from @aws-amplify/ui-angular@2.0.0
npm ERR! node_modules/@aws-amplify/ui-angular
npm ERR!   @aws-amplify/ui-angular@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

@hvergara
Copy link
Contributor

Hey @fbu-nlstbv!

Thanks for reporting it, we'll take a look and provide a solution shortly

@ericclemmons ericclemmons added the Angular An issue or a feature-request for Angular platform label Nov 19, 2021
@ericclemmons
Copy link
Contributor

Ah, let's update our Angular example to use v12:

"@angular/cli": "~11.2.14",
"@angular/compiler-cli": "~11.2.14",

@ericclemmons
Copy link
Contributor

@fbu-nlstbv We have a quick fix here:

#807

Once the e2e tests pass, we'll merge it & get it published as @aws-amplify/ui-angular@next.

Until then, does --legacy-peer-deps unblock you?

@Milan-Shah Milan-Shah added the pending-response Issue is pending response from the issue requestor label Nov 19, 2021
@fbu-nlstbv
Copy link
Author

Yes, "--legacy-peer-deps" works as a fix for now. Thanks for your fast response and I am looking forward for your fixed solution.

@ericclemmons
Copy link
Contributor

@fbu-nlstbv Can you validate that it works with @aws-amplify/ui-angular@next, too? 🙏

Re-opening until then, so that it can be officially released in #792.

@ericclemmons ericclemmons reopened this Nov 19, 2021
@fbu-nlstbv
Copy link
Author

Sorry for quickly closing the issue. Yes, npm install --save @aws-amplify/ui-angular@next works successfully with a Angular 12.2.x dependency in the package.json.

@wlee221
Copy link
Contributor

wlee221 commented Nov 23, 2021

Great! I'll close this issue then. We just released this patch to @aws-amplify/ui-angular@2.0.1, so you can now switch back to latest.

@wlee221 wlee221 closed this as completed Nov 23, 2021
thaddmt pushed a commit that referenced this issue Apr 7, 2023
chore: adding retry logic for loading CDN files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular An issue or a feature-request for Angular platform pending-response Issue is pending response from the issue requestor
Projects
None yet
Development

No branches or pull requests

5 participants