Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to latest maplibre-gl-js-amplify for maplibre v2 support #2263

Merged
merged 3 commits into from
Jul 7, 2022
Merged

chore: Update to latest maplibre-gl-js-amplify for maplibre v2 support #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac89502
Upgrade maplibre to v2
slaymance Jul 7, 2022
6a19a1a
Minor version bump changeset for ui-react
slaymance Jul 7, 2022
6c7d6d6
Increase Geo size limit
slaymance Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-foxes-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@aws-amplify/ui-react': patch
---

Update to latest version of maplibre-gl-js-amplify to support maplibre-gl v2
6 changes: 3 additions & 3 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
"deepmerge": "4.2.2",
"lodash": "4.17.21",
"mapbox-gl": "1.13.1",
"maplibre-gl": "1.15.3",
"maplibre-gl-js-amplify": "1.5.0",
"maplibre-gl": "2.1.9",
"maplibre-gl-js-amplify": "2.0.0",
"qrcode": "1.5.0",
"react-generate-context": "1.0.1",
"react-map-gl": "7.0.15"
Expand Down Expand Up @@ -134,7 +134,7 @@
"name": "Geo",
"path": "dist/esm/index.js",
"import": "{ MapView, LocationSearch }",
"limit": "300 kB"
"limit": "330 kB"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size increase is due to the addition of the Geofence feature in the upgraded maplibre-gl-js-amplify package.

Copy link
Contributor

@reesscot reesscot Jul 7, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we're OK with bumping this limit given this is a jump from 280kB to 330kB, or about an 11.5% jump for an app bundle using MapView and LocationSearch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big is the bundle now? Exactly 330k?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now:
321.52 kBwith all dependencies, minified and gzipped

}
]
}