chore(xstate): Set predictableActionArguments to true #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 66284cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wlee221
changed the title
jacoblogan
approved these changes
Sep 9, 2022
reesscot
approved these changes
Sep 9, 2022
Yes, I'll share it async. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This sets
predictableActionArugmentstotrue, as suggested inxstate@4.33.0+:We tried this in #2468, but we found some regressions with Authenticator usages. Xstate has resolved them now:
predictableActionArgumentsstatelyai/xstate#3563predictableActionArgumentsstatelyai/xstate#3549predictableActionArgumentsflag statelyai/xstate#3541Issue #, if available
See previous PR for technical details: #2468.
Description of how you validated changes
E2e test passing this time.
Notes
It's worth noting that we have some code that does not follow the best practices (statelyai/xstate#3533 (comment)). That'll be a separate refactor task, but will help prevent these problems in the future.
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.