fix(field): making description show up #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe6dab9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hein-j
previously approved these changes
Apr 7, 2023
reesscot
reviewed
Apr 7, 2023
| @@ -50,11 +50,12 @@ const FieldPrimitive: Primitive<FieldPrimitiveProps, typeof Flex> = ( | |||
| {...rest} | |||
| > | |||
| {label ? <Label visuallyHidden={labelHidden}>{label}</Label> : null} | |||
| {descriptiveText ? ( | |||
There was a problem hiding this comment.
Wait, why remove this logic? Shouldn't descriptiveText be provided to show the descriptive text?
There was a problem hiding this comment.
That logic is IN <FieldDescription>: https://github.com/aws-amplify/amplify-ui/blob/main/packages/react/src/primitives/Field/FieldDescription.tsx#L15
There was a problem hiding this comment.
but why did that cause a bug?
There was a problem hiding this comment.
This didn't cause the bug, the bug was I was passing it as a child instead of prop
reesscot
approved these changes
Apr 7, 2023
hein-j
approved these changes
Apr 7, 2023
ioanabrooks
approved these changes
Apr 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Field description wasn't showing up for the internal Field component. This fixes that.
Issue #, if available
Description of how you validated changes
Added tests
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.