feat(liveness): add credentialProvider prop #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts
Outdated
Show resolved
Hide resolved
...-liveness/src/components/FaceLivenessDetector/service/utils/__tests__/streamProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/service/utils/streamProvider.ts
Show resolved
Hide resolved
examples/next/pages/ui/components/liveness/with-credential-provider/index.page.tsx
Outdated
Show resolved
Hide resolved
ayush987goyal
previously approved these changes
Apr 28, 2023
thaddmt
added a commit
that referenced
this pull request
Jul 18, 2023
* feat(liveness): add credentialProvier prop * chore: update sdk types * chore: remove extra api definition * update yarn.lock * chore: update credential provider API based on internal review * chore: add unit tests to fix coverage * chore: address feedback * chore: add comment on why credentials are copied, fix unit tests * chore: add size limit check for react-liveness * fix: reusable unit test size check * chore: update types to better match AWS SDK types, export them as well * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * chore: switch to using credential-provider@3.310.0 * address feedback * Update packages/e2e/features/ui/components/liveness/with-credential-provider.feature * update to use more recent aws-sdk deps * try fixing deps * update aws-sdk dep to 3.350.0 * maybe this fixes it * another try * fix yarn.lock * fix e2e test --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
5 tasks
thaddmt
added a commit
that referenced
this pull request
Jul 19, 2023
* feat(liveness): add credentialProvider prop (#3790) * feat(liveness): add credentialProvier prop * chore: update sdk types * chore: remove extra api definition * update yarn.lock * chore: update credential provider API based on internal review * chore: add unit tests to fix coverage * chore: address feedback * chore: add comment on why credentials are copied, fix unit tests * chore: add size limit check for react-liveness * fix: reusable unit test size check * chore: update types to better match AWS SDK types, export them as well * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * chore: switch to using credential-provider@3.310.0 * address feedback * Update packages/e2e/features/ui/components/liveness/with-credential-provider.feature * update to use more recent aws-sdk deps * try fixing deps * update aws-sdk dep to 3.350.0 * maybe this fixes it * another try * fix yarn.lock * fix e2e test --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> * update yarn.lock * Create pretty-laws-obey.md * update ignored links * fix yarn.lock --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
thaddmt
added a commit
that referenced
this pull request
Jul 19, 2023
* feat(liveness): add credentialProvider prop (#3790) * feat(liveness): add credentialProvier prop * chore: update sdk types * chore: remove extra api definition * update yarn.lock * chore: update credential provider API based on internal review * chore: add unit tests to fix coverage * chore: address feedback * chore: add comment on why credentials are copied, fix unit tests * chore: add size limit check for react-liveness * fix: reusable unit test size check * chore: update types to better match AWS SDK types, export them as well * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * Update packages/react-liveness/src/components/FaceLivenessDetector/service/types/liveness.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * chore: switch to using credential-provider@3.310.0 * address feedback * Update packages/e2e/features/ui/components/liveness/with-credential-provider.feature * update to use more recent aws-sdk deps * try fixing deps * update aws-sdk dep to 3.350.0 * maybe this fixes it * another try * fix yarn.lock * fix e2e test --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> * update yarn.lock * Create pretty-laws-obey.md * update ignored links * fix yarn.lock * chore(docs): add liveness credential provider docs --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.